Skip to content

fix(import): handle zero values for stock use_config fields during product import#40542

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39780-import-backorders-zero-value
Open

fix(import): handle zero values for stock use_config fields during product import#40542
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39780-import-backorders-zero-value

Conversation

@lbajsarowicz
Copy link
Contributor

Description (*)

The _setStockUseConfigFieldsValues() method in the product import used !empty($value) to check if a stock field had been explicitly set in the import CSV. However, !empty(0) returns false in PHP, causing fields with a valid value of 0 (e.g. allow_backorders = 0 meaning "No Backorders") to be ignored.

As a result, use_config_backorders was never set to 0, so the imported product continued to use the system configuration default even when the CSV explicitly specified allow_backorders = 0. The same bug affects other stock fields that can have 0 as a valid value.

Fix: Changed !empty($value) to $value !== null && $value !== '' to correctly treat numeric 0 as a valid explicit value while still skipping truly empty entries (null or empty string).

Related Pull Requests

No related pull requests

Fixed Issues

Fixes #39780

Manual testing scenarios (*)

  1. Set the system default "Backorders" to "Allow Qty Below 0"
  2. Create a CSV import file with allow_backorders = 0 (No Backorders) for a product
  3. Run the product import
  4. Verify the imported product has "Backorders" set to "No Backorders" (not using the system default)

Questions or comments

No questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

…port

The _setStockUseConfigFieldsValues() method used !empty($value) to check
if a stock field had been explicitly set in the import CSV. However,
!empty(0) returns false in PHP, causing fields with a valid value of 0
(e.g. backorders = 0 meaning "No Backorders") to be ignored. As a result,
use_config_backorders was never set to 0, so the product continued to use
the system configuration default even when the CSV explicitly specified
a different value.

Changed !empty($value) to $value !== null && $value !== '' to correctly
treat numeric 0 as a valid explicit value while still skipping truly
empty entries (null or empty string).

Fixes magento#39780
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 19, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

CatalogImportExport: User needs to specify use_config_backorders = 0 if they want to import product backorders = 0

2 participants