Moo/moo 2018/improve existing switch component functionality for mx10#436
Open
SrirangK wants to merge 7 commits intoversion/mx/10from
Open
Moo/moo 2018/improve existing switch component functionality for mx10#436SrirangK wants to merge 7 commits intoversion/mx/10from
SrirangK wants to merge 7 commits intoversion/mx/10from
Conversation
| }, | ||
| "devDependencies": { | ||
| "@mendix/pluggable-widgets-tools": "~10.0.1", | ||
| "@testing-library/jest-native": "^5.4.3", |
Contributor
There was a problem hiding this comment.
is there any specific reason we have added these devdependencies here locally in switch native widget as we already have this in root package.json (as other widgets are using root dependencies for the testcases) ? If this is not required could you please remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Improvement in the Native Switch widget
Relevant changes
The Mendix switch shows the validation message in the view container of the switch which messes up the styling of the switch and its label.
Possibility to change the position of the switch in horizontal view from the right side of the label to the left side. The Mendix switch can only show the label to the right side or above the switch.