Fix: Update repeated field checks to use is_repeated property#908
Fix: Update repeated field checks to use is_repeated property#908ianmcorvidae merged 5 commits intomeshtastic:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
==========================================
+ Coverage 59.82% 59.84% +0.01%
==========================================
Files 24 24
Lines 4329 4333 +4
==========================================
+ Hits 2590 2593 +3
- Misses 1739 1740 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tested with older protobuf dependencies and we'd need bump to >=6.31.0 or add a fallback. |
|
Helper function added to test for is_repeated and fallback to label if not present. |
ianmcorvidae
left a comment
There was a problem hiding this comment.
Looks pretty good. Left a small documentation comment that I'll let you approve or amend first, but we can get this in and released soon hopefully.
Co-authored-by: Ian McEwen <ianmcorvidae@ianmcorvidae.net>
|
Heh, apparently my suggestion angered pylint. I'll fix that up, sorry about that. |
Update protobuf field-inspection logic to use is_repeated instead of label where needed.
I have not tested for backwards compatibility.