Conversation
compulim
changed the title
npm run build jobnpm run build job
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath and
tdurnford
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes the PR validation build by packaging workspace outputs once and reusing them across subsequent jobs, reducing duplicated npm run build work and improving artifact consistency between jobs.
Changes:
- Add a build step to
npm packall workspaces, bundle the resulting.tgzfiles into a single tar artifact, and upload it for downstream jobs. - Update several jobs (static analysis, unit tests, type-definition tests) to download/extract/unpack the shared tarballs instead of rebuilding.
- Expand
build-browserverification to run on a macOS/Ubuntu/Windows matrix, and update.gitignoreentries to ignore generated.tgz/.tarartifacts.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pull-request-validation.yml | Packs workspace tarballs in build, uploads them as an artifact, and updates downstream jobs to reuse them; expands build-browser to a 3-OS matrix. |
| .gitignore | Ignores root-level *.tar artifacts produced by the workflow. |
| packages/vibe-grep/.gitignore | Ignores workspace-produced .tgz tarballs and node_modules/. |
| packages/test/web-server/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns (dist/, node_modules/). |
| packages/test/test-assets/.gitignore | Ignores workspace .tgz tarballs. |
| packages/test/page-object/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/test/harness/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/test/dev-server/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/support/cldr-data/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/support/cldr-data-downloader/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/repack/react@umd/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react@baseline/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react-is/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react-dom@umd/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react-dom@baseline/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/react-dom/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/object-assign/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/microsoft-cognitiveservices-speech-sdk/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/html-react-parser/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/botframework-directlinejs/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/base64-js/.gitignore | Ignores workspace .tgz tarballs. |
| packages/repack/adaptivecards/.gitignore | Ignores workspace .tgz tarballs. |
| packages/isomorphic-react/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
| packages/isomorphic-react-dom/.gitignore | Ignores workspace .tgz tarballs; normalizes ignored folder patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
(No changelog for workflow update.)
Description
Today, every job in the pull request validation workflow run
npm run buildon their own.Tomorrow, we centralize the
npm run buildand pack/upload the artifact. So all jobs will use the very same artifacts.Design
The bigger idea: use
npm packandtar -xf --strip-components=1to pack/unpack/dist/et al. This should work because all build artifacts should be included bypackage.json/files.The idea:
npm clean-installnpm run buildnpm pack, note: the tarball filenames are not straightforward to compute frompackage.json/[name|version]/**/*.tgzrecursively without flattening folder structuretar -xf *.tgzin their respective package foldernpm clean-installto rehydratesnode_modules, needed to runbundleas it depends oncoreet al.*.tgzback to their original package foldernpm exec --workspaces --call 'tar -xf *.tgz --strip-components=1 --skip-old-files'--callis needed fortar*.tgzin-place--strip-components=1because this isnpm pack, it always pack into/package/--skip-old-filesis optional, feel better with itnpm pack --workspacesvs.npm exec --workspaces -- npm packnpm pack --workspaceswill have pack destination at the root package.npm exec --workspaces -- npm packwill have pack destination at individual package.Specific Changes
.gitignoreto ignore .tgz/.tarI have added tests and executed them locallyI have updatedCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)