Restore original log levels in logging refactor#429
Merged
Conversation
- Replace log alias (log "github.com/sirupsen/logrus") in mlflow package with direct "github.com/sirupsen/logrus" import - Convert all log.Printf/log.Println calls to proper logrus level methods (logrus.Infof, logrus.Debugf, logrus.Errorf, logrus.Warnf) - Add consistent "mlflow:" prefix to all mlflow log messages matching the existing "component: action" pattern used across the backend package - Replace stdlib log.Fatal with logrus.Fatal in cmd/root.go - Remove unused stdlib "log" import from cmd/root.go Co-authored-by: chlins <31262637+chlins@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor logging for consistent and standardized style
Standardize logging to use logrus consistently across the repository
Feb 27, 2026
- Use concise, action-oriented messages (remove verbose "starting...operation" phrasing) - Remove redundant "successfully" from completion messages (success is implied) - Move config/struct dumps (%+v) from Info to Debug level - Move internal operation details (digest calculation, cache hits, metadata) to Debug - Add consistent component prefix to all logs (builder:, codec:, remote:, progress:) - Use natural English phrasing (e.g., "pulling artifact" not "starting pull operation") - Standardize wording patterns across all backend operations Co-authored-by: chlins <31262637+chlins@users.noreply.github.com>
Address code review feedback: completion messages now use natural "verb noun" order (e.g., "pushed artifact" not "artifact pushed") for better readability and consistency with start messages. Co-authored-by: chlins <31262637+chlins@users.noreply.github.com>
Copilot
AI
changed the title
Standardize logging to use logrus consistently across the repository
Standardize logging across codebase: levels, prefixes, and wording
Mar 3, 2026
Revert all log level changes (Infof→Debugf) back to their original levels. The wording and structure improvements are kept, but the log levels now match the original code. Files updated: - pkg/backend/attach.go (3 Debugf→Infof) - pkg/backend/build.go (2 Debugf→Infof) - pkg/backend/build/builder.go (4 Debugf→Infof) - pkg/backend/processor/base.go (1 Debugf→Infof) - pkg/backend/pull.go (1 Debugf→Infof) - pkg/modelprovider/mlflow/downloader.go (2 Debugf→Infof) Co-authored-by: chlins <31262637+chlins@users.noreply.github.com>
Copilot
AI
changed the title
Standardize logging across codebase: levels, prefixes, and wording
Restore original log levels in logging refactor
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logging refactor changed both message wording and log levels. This PR reverts the level changes while keeping the improved wording — log levels are intentional and should not be adjusted as part of a wording cleanup.
Changes
Debugf→Infofreversions across 6 files, restoring original levels:pkg/backend/attach.go(3)pkg/backend/build.go(2)pkg/backend/build/builder.go(4)pkg/backend/processor/base.go(1)pkg/backend/pull.go(1)pkg/modelprovider/mlflow/downloader.go(2)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.