Open
Conversation
This was in response to the below warning, which was polluting test outputs making them rather difficult to read: You must assign calls to 'orderly_parameters()' to a variable i The old behaviour of automatically copying parameters into the environment has been deprecated, and you should move to the new behaviour as soon as possible
david-mears-2
commented
Mar 5, 2026
Comment on lines
195
to
+197
| task_ids <- c(r1, "non-existent-id") | ||
|
|
||
| res <- q$get_status(task_ids, include_logs = FALSE) | ||
| res <- suppressWarnings(q$get_status(task_ids, include_logs = FALSE)) |
Contributor
Author
There was a problem hiding this comment.
Warning is expected because the job does not exist
M-Kusumgar
approved these changes
Mar 5, 2026
Contributor
M-Kusumgar
left a comment
M-Kusumgar
left a comment
There was a problem hiding this comment.
LGTM, could you add quiet = TRUE to install.packages when it installs "mime" in test-zzz-e2e.R or did you not do it given that its temporary and youll rip it out anyway? either way is fine!
This test was checking that null was equal to null, because 'res' dollar 'data' is null. The initial intent was probably to check that the preexisting git repos have not changed in this later response as compared to the earlier ones.
Contributor
Author
|
I've quieted that installation, and I've also added a commit that fixes a vacuous test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were lots of warnings in test output, which was polluting test outputs making them rather difficult to read.
Most of these were orderly warnings about a deprecated syntax.
Also: suppressed an expected warning - that line deliberately requests a non-existent job.