Skip to content

Fix missing due date remember icons#7626

Draft
theoholl wants to merge 2 commits intomainfrom
7511-missing-icons-on-shared-boards-dropdown
Draft

Fix missing due date remember icons#7626
theoholl wants to merge 2 commits intomainfrom
7511-missing-icons-on-shared-boards-dropdown

Conversation

@theoholl
Copy link
Contributor

@theoholl theoholl commented Feb 8, 2026

Summary

  • Fix Vue warning Invalid prop: type check failed for prop "disabled". Expected Boolean, got String with value "all".

TODO / WIP

Board settings including the settings for the due date reminder are not loaded on the initial page load: created() lifecycle hook in App.vue -> Vuex store action loadBoards() in main.js -> loadBoards() in BoardApi.js -> findAll() in BoardSevice.php which loads the boards with ... fullDetails = false.

We could e.g. change the enrichBoards method to always enrich with board settings, potentially loading too much information in other places, or load the boards with full details which then probably includes lots of information that we don't need here, or we could change some method signatures to load exactly the data we need?

@theoholl theoholl linked an issue Feb 8, 2026 that may be closed by this pull request
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

theoholl added 2 commits March 4, 2026 13:48
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl force-pushed the 7511-missing-icons-on-shared-boards-dropdown branch from a44388d to 68f00be Compare March 4, 2026 13:48
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84616 was 84323 (+0.34%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing icons on shared boards dropdown

1 participant