Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
a44388d to
68f00be
Compare
|
🐢 Performance warning. |
Summary
Invalid prop: type check failed for prop "disabled". Expected Boolean, got String with value "all".TODO / WIP
Board settings including the settings for the due date reminder are not loaded on the initial page load:
created()lifecycle hook inApp.vue-> Vuex store actionloadBoards()inmain.js->loadBoards()inBoardApi.js->findAll()inBoardSevice.phpwhich loads the boards with ...fullDetails = false.We could e.g. change the
enrichBoardsmethod to always enrich with board settings, potentially loading too much information in other places, or load the boards with full details which then probably includes lots of information that we don't need here, or we could change some method signatures to load exactly the data we need?