Skip to content

feat: allow automatic setting of 'done' status#7702

Open
miaulalala wants to merge 2 commits intomainfrom
feat/noid/add-automation-to-mark-card-done
Open

feat: allow automatic setting of 'done' status#7702
miaulalala wants to merge 2 commits intomainfrom
feat/noid/add-automation-to-mark-card-done

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 2, 2026 •
edited
Loading

Fixes #5485

  • Target version: main

Summary

Allow defining a column as "done" column

  • A card will be moved to the "done" column when marked as done
  • A card will be marked as "done" when moved to the column
  • When cards already exist in the "done" column, they're marked as "done" when the column is set.

Video:

Screencast.from.2026-03-02.19-51-05.webm

TODO

  • Capabilities docs need updating, unsure if there's a script or if I should do that manually

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@miaulalala miaulalala self-assigned this Mar 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 93108 was 84323 (+10.41%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 93104 was 84323 (+10.41%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 93130 was 84323 (+10.44%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@miaulalala miaulalala requested a review from blizzz March 2, 2026 20:39
luka-nextcloud
luka-nextcloud requested changes Mar 3, 2026
View reviewed changes
@luka-nextcloud
Copy link
Contributor

luka-nextcloud commented Mar 3, 2026

@miaulalala Could you please squash your commits? Thank you for your contribution.

@miaulalala miaulalala force-pushed the feat/noid/add-automation-to-mark-card-done branch from f76aadf to df1c0aa Compare March 3, 2026 13:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 93102 was 84323 (+10.41%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@luka-nextcloud
Copy link
Contributor

luka-nextcloud commented Mar 3, 2026

@miaulalala Thanks, could you also update the query count in tests/integration/base-query-count.txt to 93102?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 94739 was 93102 (+1.75%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@miaulalala
feat: allow automatic setting of 'done' status
b81bfb6 
Fixes #5485

- Marking a column to set cards as done when added to it

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
chore: update base query count
93073a7 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/noid/add-automation-to-mark-card-done branch from 7a0fd7e to 93073a7 Compare March 5, 2026 06:48
@miaulalala
Copy link
Contributor Author

miaulalala commented Mar 5, 2026

@grnd-alt I switched the new endpoints to the OCS controller

grnd-alt
grnd-alt requested changes Mar 5, 2026
View reviewed changes
lib/Capabilities.php
'deck' => [
'version' => $this->appManager->getAppVersion('deck'),
'canCreateBoards' => $this->permissionService->canCreate(),
'supportsDoneColumn' => true,
Copy link
Member

@grnd-alt grnd-alt Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these capabilities are only returned for logged in users. For API requests (and federated requests) only the public capabilities will be returned. As federation is not yet published, there are no instances that have federation but no supportsDoneColumn, so we can drop this check.

tests/integration/features/bootstrap/BoardContext.php
public function setsTheCurrentStackAsDoneColumn() {
$this->requestContext->sendJSONrequest(
'PUT',
'/index.php/apps/deck/stacks/' . $this->stack['id'] . '/done',
Copy link
Member

@grnd-alt grnd-alt Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still the non-ocs endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt requested changes

@elzody elzody Awaiting requested review from elzody elzody is a code owner

@blizzz blizzz Awaiting requested review from blizzz

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@miaulalala miaulalala

Labels

3. to review feature: stacks Stacks / Lists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark cards as done automatically when dragging into list

3 participants

@miaulalala @luka-nextcloud @grnd-alt