Skip to content

fix: pass boardId to attachmentController#7708

Open
grnd-alt wants to merge 1 commit intomainfrom
fix/federation-wrong-references
Open

fix: pass boardId to attachmentController#7708
grnd-alt wants to merge 1 commit intomainfrom
fix/federation-wrong-references

Conversation

@grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Mar 4, 2026

this PR prevents requests on federated boards from being wrongly associated.
By passing the current boardId to the controller we can check if the board is a federated board and then block the request.

If the boardId is not passed we assume the board is local, as the client knows what it received from the BE before, and can that way spare the query to get the localBoard (in a future pr).

An attempt to show the error that currently happens and requires the change:
image

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84627 was 84323 (+0.36%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt grnd-alt force-pushed the fix/federation-wrong-references branch from 209592f to 83478a3 Compare March 4, 2026 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84624 was 84323 (+0.35%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt grnd-alt marked this pull request as ready for review March 4, 2026 14:02
@grnd-alt grnd-alt requested review from blizzz and juliusknorr March 4, 2026 14:03
@grnd-alt grnd-alt force-pushed the fix/federation-wrong-references branch from 83478a3 to 5f23187 Compare March 5, 2026 11:22
@grnd-alt grnd-alt requested a review from blizzz March 5, 2026 11:22
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84618 was 84323 (+0.34%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Mar 5, 2026
@grnd-alt grnd-alt moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Mar 5, 2026
@grnd-alt grnd-alt self-assigned this Mar 5, 2026
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt grnd-alt force-pushed the fix/federation-wrong-references branch from 5f23187 to d14b202 Compare March 5, 2026 13:32
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84623 was 84323 (+0.35%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants