nirfsg: Refactor get_deembedding_sparameters to match the interpreter interfaces#2167
Open
nirfsg: Refactor get_deembedding_sparameters to match the interpreter interfaces#2167
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2167 +/- ##
==========================================
- Coverage 91.15% 90.13% -1.02%
==========================================
Files 67 71 +4
Lines 16477 18670 +2193
==========================================
+ Hits 15020 16829 +1809
- Misses 1457 1841 +384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…erpreted as an integer' in 'SetAttributeVi' methods
vnktshr21
reviewed
Mar 5, 2026
src/nirfsg/templates/_library_interpreter.py/get_deembedding_sparameter.py.mako
Outdated
Show resolved
Hide resolved
src/nirfsg/templates/_library_interpreter.py/get_deembedding_sparameter.py.mako
Show resolved
Hide resolved
src/nirfsg/templates/_library_interpreter.py/get_deembedding_sparameter.py.mako
Outdated
Show resolved
Hide resolved
src/nirfsg/templates/_library_interpreter.py/get_deembedding_sparameter.py.mako
Show resolved
Hide resolved
vnktshr21
reviewed
Mar 6, 2026
src/nirfsg/templates/_grpc_stub_interpreter.py/get_deembedding_sparameter.py.mako
Outdated
Show resolved
Hide resolved
ni-jfitzger
reviewed
Mar 6, 2026
ni-jfitzger
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
What testing has been done?