Conversation
rahur-NI
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2168 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 71 71
Lines 18670 18669 -1
=======================================
Hits 16828 16828
+ Misses 1842 1841 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
vnktshr21
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
create_deembedding_sparameter_table_arraymethod has two 'len' parameters (frequenciesSize and sparameterTableSize) which can be calculated in _library_interpreter. But since our repo had limitations to support multiple len parameters, sparameterTableSize was passed throughcreate_deembedding_sparameter_table_array.py.makotemplate into sesssion.py.After Multiple len parameter handling support, _library_interpreter codegen can handle multiple len parameters.
This PR is to leverage the same and remove respective changes from session.py's template.
List issues fixed by this Pull Request below, if any.
What testing has been done?
create_deembedding_sparameter_table_arraymethod in grpc and library. gRPC will be enabled for nirfsg through upcoming PRs.