doc: clarify that any truthy value of shell is part of DEP0190#62249
Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
Open
doc: clarify that any truthy value of shell is part of DEP0190#62249aduh95 wants to merge 2 commits intonodejs:mainfrom
shell is part of DEP0190#62249aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
deprecations
aduh95
added
the
dont-land-on-v20.x
Renegade334
reviewed
Mar 14, 2026
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
Renegade334
approved these changes
Mar 14, 2026
aduh95
added
author ready
cjihrig
approved these changes
Mar 14, 2026
lpinca
approved these changes
Mar 14, 2026
aduh95
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wording makes it sound like passing a string would not be a problem, remove the mention of
truein the title and add an example with a string