test_runner: add context subtests expectFailure only skip todo#62263
Open
JakobJingleheimer wants to merge 2 commits intonodejs:mainfrom
Open
test_runner: add context subtests expectFailure only skip todo#62263JakobJingleheimer wants to merge 2 commits intonodejs:mainfrom
expectFailure only skip todo#62263JakobJingleheimer wants to merge 2 commits intonodejs:mainfrom
Conversation
Co-Authored-By: Heath Dutton🕴️ <heathdutton@linux.com> Co-Authored-By: Felipe <60716370+felipeness@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
avivkeller
approved these changes
Mar 15, 2026
pmarchini
approved these changes
Mar 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62263 +/- ##
==========================================
- Coverage 89.65% 89.65% -0.01%
==========================================
Files 676 676
Lines 206555 206564 +9
Branches 39547 39550 +3
==========================================
- Hits 185195 185189 -6
- Misses 13495 13509 +14
- Partials 7865 7866 +1
🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Mar 15, 2026
atlowChemi
added
request-ci
H4ad
reviewed
Mar 15, 2026
|
|
||
| test = ObjectAssign((...args) => this.#runTest(...args), { | ||
| __proto__: null, | ||
| expectFailure: (name, opts, fn) => this.#runTest(name, opts, fn, { __proto__: null, expectFailure: true }), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61251
Closes #62156
Fixes #50665