url: optimize URLSearchParams set/delete duplicate handling#62266
Open
gurgunday wants to merge 1 commit intonodejs:mainfrom
Open
url: optimize URLSearchParams set/delete duplicate handling#62266gurgunday wants to merge 1 commit intonodejs:mainfrom
gurgunday wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62266 +/- ##
==========================================
- Coverage 89.68% 89.67% -0.02%
==========================================
Files 676 676
Lines 206495 206576 +81
Branches 39537 39564 +27
==========================================
+ Hits 185204 185243 +39
- Misses 13435 13458 +23
- Partials 7856 7875 +19
🚀 New features to boost your workflow:
|
Member
|
@gurgunday can we split this PR in two, so we can have benchmark introduced first and then the improvements? Or maybe split in two commits, then we can try use the benchmark commit as base to test the improvements on our CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes set and delete to use a single pass instead of repeated array.splice() while scanning
master:
branch: