Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
scheidtdav
approved these changes
Mar 13, 2026
Member
scheidtdav
left a comment
There was a problem hiding this comment.
Looks good to me!
Only thing that might be missing is disabling features via the api. I think we decided to make archived devices truely read-only. So I think we should prevent people from modifying stuff or sending data, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
add archived_at field on device schema
create stored procedure to archive inactive devices
add cronjob to run stored procedure periodically
grey out archived devices in device-datatable and disable most functions
Dependency upgrade
Bug fix (non-breaking change)
Breaking change
New feature
Code quality improvements
Implementation
Checklist
devbranchAdditional Information