Open
Conversation
This commit acts as a squash of the thumbnail cache refactoring and avatar fixes. See PR description for full details.
- Update FILE_PREVIEW_URI to use direct native /webdav path. - Use Graph API explicitly for fetching Avatar image, dropping the /index.php/avatar hack & interceptor fallbacks.
TUS PATCH responses from openCloud do not include ETag headers. This caused large file uploads (>10MB) to have null ETags in the local database, breaking thumbnail preview URLs and caching. Changes: - TusUploadHelper: after TUS upload completes, perform a PROPFIND to fetch the file's ETag from the server - PatchTusUploadChunkRemoteOperation: extract ETag from PATCH response header (for future backend support) - UploadFileFromFileSystemWorker: persist ETag to database for both overwrite and non-overwrite uploads - ThumbnailsRequester: use .orEmpty() for null-safe ETag formatting
Also fix avatar for multiple accounts on same server.
Before the etag was set to empty for non-downloaded files. We need it for a proper cache key.
The avatar is assigned very early in the flow while refreshing the access token did not pass yet leading to 401. The cache does not help as it insists on a refresh. This is probably a regression from switching from our own cache to coil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on top of PR #85:
revalidation + offline fallback)
@zerox80 Please have a look