[MNT] Mock live server calls in test_supervised_task.py#1691
Open
Dijo-404 wants to merge 3 commits intoopenml:mainfrom
Open
[MNT] Mock live server calls in test_supervised_task.py#1691Dijo-404 wants to merge 3 commits intoopenml:mainfrom
Dijo-404 wants to merge 3 commits intoopenml:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to convert tests/test_tasks/test_supervised_task.py away from live server usage by introducing mocks/patches for task retrieval and get_X_and_y().
Changes:
- Removed live
get_task(...)usage fromOpenMLSupervisedTaskTest.test_get_X_and_Y. - Added
unittest.mock-based mocking (MagicMock,patch) to avoid network calls. - Minor cleanup in base-class skip message / imports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
test_tasks/test_supervised_task.py]test_tasks/test_supervised_task.pyDetails
test_tasks/test_supervised_task.pyto use mocks/patches instead of making direct connections to the live remote server.