Open
Conversation
e446496 to
5da50fb
Compare
Signed-off-by: Farès Chati <fchati@smartandconnective.com>
5da50fb to
a79bf15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing the following type of schema definition:
{ "definitions": { "Value": { "type": [ "array", "boolean", "integer", "number", "object", "string" ] } } }The following rust type is generated:
This is mostly what we want but the issue here is the ordering. The use of a
BTreeMapnot only deduplicates but also re-orders the types to follow the ordering of theInstanceTypeenum fromschemarswhich puts theNumbertype before theIntegertype.This makes the
Integervariant of ourValueenum here unreachable as all possible values can already be matched by theNumbervariant.I believe that forcing the re-ordering of the variant instead of following the ordering declared in the schema is a good thing but it should be slightly tweaked.
This PR introduces an intermediate re-definition of this
InstanceTypeenum with re-ordered fields and uses it for this BTreeMap deduplication.This in terms, gives us the following rust enum definition: