docs: How to add support for ES6 syntax#50
Open
rubydusa wants to merge 1 commit intopaperjs:masterfrom
Open
Conversation
Member
|
Yes this is a bit of a legacy reason, in 2023 it doesn't make sense to include such an old version of acorn.js, we should simply not ship with it at all, because bundling the new version would make the library much larger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm just being stupid, but it seems that simply installing the latest version of paper.js through the downloads section or through npm results in a version of paper.js that doesn't support es6 syntax.
As far as I could tell, the official solution is to load a version of acorn.js that does support es6 and then paper.js will prefer the loaded version when parsing paperscript.
Issues for reference:
paperjs/paper.js#1183
paperjs/paper.js#1357
This PR explains in the getting started tutorial how to overcome the issue.