Skip to content

Add group_rollup_mode#3132

Merged
texodus merged 2 commits intomasterfrom
leaves-only-exclusively
Mar 9, 2026
Merged

Add group_rollup_mode#3132
texodus merged 2 commits intomasterfrom
leaves-only-exclusively

Conversation

@texodus
Copy link
Member

@texodus texodus commented Mar 4, 2026

  • Breaking Replaces the per-query leaves_only parameter (on to_columns/to_rows/to_ndjson) with a new group_rollup_mode property of ViewConfig, making leaf-only behavior a first-class view setting rather than a serialization option.
  • Adds a GroupRollupMode enum with "rollup" and "flat" variants to the protobuf schema and Rust client config, with a commented-out Total variant for future use.
  • Refactors C++ engine traversal logic — moves row filtering from view.cpp into traversal.cpp and tree_context_common.cpp, so contexts handle rollup/flat modes natively.
  • Adds UI support, a group_rollup_mode dropdown selector in the config panel., with corresponding LESS styling.
  • Adds plugin metadata support (group_rollups) for datagrid and d3fc plugins, including datagrid rendering changes for flat mode (hiding tree expanders, adjusting column headers).
Screen.Recording.2026-03-03.at.11.31.13.PM.mov

@texodus texodus added the enhancement Feature requests or improvements label Mar 4, 2026
@texodus texodus force-pushed the leaves-only-exclusively branch from bb30c4d to 5199057 Compare March 4, 2026 16:04
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the leaves-only-exclusively branch 3 times, most recently from 87aa428 to 80bcc8f Compare March 7, 2026 16:49
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the leaves-only-exclusively branch from 80bcc8f to 4e41d33 Compare March 7, 2026 20:51
@texodus texodus marked this pull request as ready for review March 9, 2026 04:58
@texodus texodus merged commit 45bd629 into master Mar 9, 2026
16 checks passed
@texodus texodus deleted the leaves-only-exclusively branch March 9, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking enhancement Feature requests or improvements

Development

Successfully merging this pull request may close these issues.

1 participant