Skip to content

Migrate tests from v1 to v2 for removed endpoints#712

Merged
ziimk merged 1 commit intomasterfrom
update-tests-for-315
Mar 9, 2026
Merged

Migrate tests from v1 to v2 for removed endpoints#712
ziimk merged 1 commit intomasterfrom
update-tests-for-315

Conversation

@ziimk
Copy link
Contributor

@ziimk ziimk commented Mar 9, 2026

Related Tickets & Documents

Description

This PR updates the functional test suite to reflect the API changes introduced in branch 315, where several v1 endpoints and the ActivitiesApi were removed from v1 exports.

Changes:

  • Deleted test/functional/v1/deal.test.ts — all tested methods (getDeals, addDeal, getDeal, updateDeal, deleteDeal) were removed from v1. These are already covered by the existing test/functional/v2/deal.test.ts.
  • Moved test/functional/v1/activities.test.ts → test/functional/v2/activities.test.ts — ActivitiesApi was removed from v1 exports entirely. The test was migrated to v2 with the following adjustments:
    • Imports updated to dist/versions/v2
    • GetActivityResponse → UpsertActivityResponse
    • UpdateActivityRequest → AddActivityRequest (v2 reuses the same request type for updates)
    • Update test uses PATCH instead of PUT

Type of PR?

Manual testing

Automated tests added?

  • 👍 Unit tests
  • 👍 Functional tests
  • 👍 E2E tests
  • 🙅 N/A

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ziimk ziimk merged commit 1b9afdd into master Mar 9, 2026
1 check passed
@ziimk ziimk deleted the update-tests-for-315 branch March 9, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants