fix: Consistently use overriden config paths with -config flag#1346
fix: Consistently use overriden config paths with -config flag#1346jentfoo wants to merge 10 commits intoprojectdiscovery:devfrom
Conversation
…ion-strategy feat(server) added eviction strategy
…-1275-feature/eviction-strategy Revert "feat(server) added eviction strategy"
interactsh v1.3.0
Bumps [github.com/refraction-networking/utls](https://github.com/refraction-networking/utls) from 1.8.0 to 1.8.2. - [Release notes](https://github.com/refraction-networking/utls/releases) - [Commits](refraction-networking/utls@v1.8.0...v1.8.2) --- updated-dependencies: - dependency-name: github.com/refraction-networking/utls dependency-version: 1.8.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…abot/go_modules/github.com/refraction-networking/utls-1.8.2 chore(deps): bump github.com/refraction-networking/utls from 1.8.0 to 1.8.2
release interactsh v1.3.1
When -config is provided, goflags' Parse() still attempts to read the default config path first, causing errors like:
[FTL] Could not parse options: open /home/USER/.config/interactsh-server/config.yaml: read-only file system
This change scans os.Args for -config before Parse() and call SetConfigFilePath() so goflags uses the custom path from the start. The post-parse MergeConfigFile/FileExists checks are removed since Parse() already performs the same existence check and merge internally.
Applied to both interactsh-server and interactsh-client.
Neo - PR Security ReviewNo security issues found Highlights
Hardening Notes
Comment |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughConfiguration file handling is refactored in both client and server main modules to detect custom Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When
-configis provided, goflags'Parse()still attempts to read the default config path first, causing errors like:This change scans
os.Argsfor-configbeforeParse()and callSetConfigFilePath()so goflags uses the custom path from the start. The post-parse MergeConfigFile/FileExists checks are removed sinceParse()already performs the same existence check and merge internally.Applied to both interactsh-server and interactsh-client.
Summary by CodeRabbit
-configor--configcommand-line flags are now properly recognized and loaded. Both the standard flag forms (e.g.,-config=PATHand--config=PATH) are now correctly handled before command-line option processing.