Skip to content

Adapt Engine to api camera#35

Merged
fe51 merged 7 commits intomainfrom
engine-api-camera
Mar 20, 2026
Merged

Adapt Engine to api camera#35
fe51 merged 7 commits intomainfrom
engine-api-camera

Conversation

@fe51
Copy link
Member

@fe51 fe51 commented Mar 19, 2026

Desc more detailed to come, to be merged after #34 (based on it)

Main modifications are:

  • Remove old engine stack: deleted pyro_engine, reolinkdev1, reolinkdev2 services from docker-compose.yml and their container code in containers/
  • Updates engine profile : pyro_camera_api and engine are now the sole engine profile
  • New Makefile targets: run-engine, stop-engine, restart-engine (restarts engine only, skips init_script re-run)
  • Cleanup: removed reolink builds from make build, dropped run-all and old engine-related targets

Alos, bonus, no dedicated PR because small :

  • MinIO named volume: replaced ./data/minio bind mount with minio_data named volume so make stop properly cleans it up

@MateoLostanlen
Copy link
Member

Hi @fe51, only this token management issue and we are go to go !

@fe51
Copy link
Member Author

fe51 commented Mar 20, 2026

I have taken your comment about token in account. In fact, there was an issue as long as token or not, it should work anytime when starting up or restarting engine.

  • Removed depends_on engine as long as in some case it should work without the rest of devenv (could be discussed)
  • In make run-tools-and-engine, I ran docker up in two make steps to ensure that the init script and all backend were up before starting the engine; otherwise, it caused token synchronisation issues.

I think we are good to go now

@fe51 fe51 requested a review from MateoLostanlen March 20, 2026 08:20
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks !

@fe51 fe51 merged commit 48606be into main Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants