[tqdm] Add thread_map and process_map type hints#15460
Merged
srittau merged 2 commits intopython:mainfrom Mar 2, 2026
Merged
Conversation
hoel-bagard
force-pushed
the
tqdm/process_map
branch
from
9d7f771 to
3bfbabc
Compare
hoel-bagard
changed the title
tqdm: add thread_map and process_map type hintsthread_map and process_map type hints
hoel-bagard
changed the title
thread_map and process_map type hintsthread_map and process_map type hints
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Mar 2, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, this looks very useful! One note.
| _T4 = TypeVar("_T4") | ||
| _T5 = TypeVar("_T5") | ||
|
|
||
| class _TqdmKwargs(TypedDict, total=False): |
Collaborator
There was a problem hiding this comment.
This needs the @type_check_only decorator from typing.
srittau
approved these changes
Mar 2, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the overloads, I've taken that approach from
map.