Add version locking and CI for the conformance suite#2200
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Feb 28, 2026
Merged
Add version locking and CI for the conformance suite#2200JelleZijlstra merged 3 commits intopython:mainfrom
JelleZijlstra merged 3 commits intopython:mainfrom
Conversation
carljm
approved these changes
Feb 28, 2026
JelleZijlstra
commented
Feb 28, 2026
| @@ -1,6 +1,5 @@ | |||
| conformant = "Pass" | |||
| output = """ | |||
| qualifiers_final_decorator.py:8:6 - warning: Import "_qualifiers_final_decorator" could not be resolved from source (reportMissingModuleSource) | |||
Member
Author
There was a problem hiding this comment.
Not sure why this changed
JelleZijlstra
commented
Feb 28, 2026
|
|
||
| def has_int_and_str(a: int, b: str, c: float, d: complex): | ||
| assert_type(func3(a, b, c, d), tuple[float, str, complex]) | ||
| assert_type(func3(a, b, c, d), tuple[complex, str, float]) |
Member
Author
There was a problem hiding this comment.
This was wrong. We call func3 with arguments (int, str, float, complex), so we get Ts = (str, float) and T = complex. func3 returns tuple[T, *Ts], so (complex, str, float).
Contributor
There was a problem hiding this comment.
Yeah, sorry for that. I probably pulled in a change from Alex without rerunning tests.
Member
There was a problem hiding this comment.
My bad really, I think I gave you the buggy suggestion!
AlexWaygood
added
the
topic: conformance tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current system where we always pick the latest version of every type checker causes some changes to randomly pick up unrelated upgrades to type checkers, which makes it more difficult to make focused changes.
We were also not checking in CI that the conformance results were correct. This change introduces a GitHub action to do that, which exposed a bug due to a recent change in the typevartuple test.