source: preserve Position arg in ObjectUriBatchReader#5922
Open
noam-sol wants to merge 2 commits intoquickwit-oss:mainfrom
Open
source: preserve Position arg in ObjectUriBatchReader#5922noam-sol wants to merge 2 commits intoquickwit-oss:mainfrom
noam-sol wants to merge 2 commits intoquickwit-oss:mainfrom
Conversation
dbcc250 to
9d1868c
Compare
Member
|
This is not the right fix. It's a bug in the checkpoint delta logic in the source. If you print the batch checkpoint deltas in that unit test, you will see something like: for batch in batches {
println!("batch checkpoint delta: {:?}", batch.checkpoint_delta);
}The first checkpoint delta should be Do you want to take a stab at it? |
Author
|
ahh I see, on this line - we lose the granularity between Beginning and offset 0; however I don't feel like properly fixing it is worth the risk of breaking something |
Member
|
This is the right fix and we're not going to break anything. I will not merge this PR as is. |
I will remove is_eof on a next commit, so remove a usage of it.
Before the fix, we lose the granularity between Beginning and offset 0 which affects the output checkpoint_delta.
9d1868c to
dcc9cec
Compare
Author
|
@guilload I updated the branch to fix the issue as you suggested, and added a UT as well. Thanks for the feedback! Do you have any other ideas on how to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before the fix, we lose the granularity between Beginning and offset 0 which
affects the output checkpoint_delta.
How was this PR tested?
Added a UT