feat(understack-workflows): more clearly report SVM state#1843
Merged
Conversation
More clearly report if the SVM was created, removed, present, nonexistent, or unknown so that the workflow can make other operational choices on that data. Some tests needed to be updated to use mock_open instead of a regular Mock, which is required to have a compatible opened file for mocking.
The keystone test had the open() mock wrong so tests were unable to properly pass. Use the new_callable so we use the mock_open() instead of a regular Mock(). Fix up the remaining tests so that everything is consistent.
cardoe
force-pushed
the
storage-flow
branch
2 times, most recently
from
ec844ed to
6623983
Compare
nidzrai
approved these changes
Mar 19, 2026
skrobul
reviewed
Mar 19, 2026
| - name: extra_vars | ||
| value: {{ printf "project_id={{steps.convert-project-id.outputs.result}} dry_run=false" | quote }} | ||
|
|
||
| - - name: ansible-remove-project |
Collaborator
There was a problem hiding this comment.
does that name not need to be unique?
When the SVM is removed we need to run a playbook and when the project itself is being removed we need to run another playbook. Wire those in so that they execute correctly.
skrobul
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More clearly report if the SVM was created, removed, present,
nonexistent, or unknown so that the workflow can make other operational
choices on that data. Some tests needed to be updated to use mock_open
instead of a regular Mock, which is required to have a compatible opened
file for mocking.