RDBC-1031 Default CounterOperation.INCREMENT delta to 1#267
Open
redknightlois wants to merge 1 commit intoravendb:v7.1from
Open
RDBC-1031 Default CounterOperation.INCREMENT delta to 1#267redknightlois wants to merge 1 commit intoravendb:v7.1from
redknightlois wants to merge 1 commit intoravendb:v7.1from
Conversation
…mitted C# CounterOperation for INCREMENT defaults delta to 1 when not provided. Python was raising ValueError instead. Fix assigns delta=1 on the client when delta is None, matching the C# client's permissive default. Regression test: test_counter_increment_default_delta.py verifies that omitting delta results in total=21 after two increments (explicit 20 + implicit 1).
72daa2d to
7529974
Compare
CounterOperation.create_increment(name) without delta raises ValueError - should default to 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1031
Additional description
CounterOperation.INCREMENTraised aValueErrorwhendeltawas omitted, but the C# client defaults it to1in that case. Fixed by assigningdelta = 1instead of raising, matching the reference client behaviour.Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.