Skip to content

RDBC-1040 Add JavaScriptArray.remove_all(predicate) method#280

Open
redknightlois wants to merge 1 commit intoravendb:v7.1from
redknightlois:RDBC-1040
Open

RDBC-1040 Add JavaScriptArray.remove_all(predicate) method#280
redknightlois wants to merge 1 commit intoravendb:v7.1from
redknightlois:RDBC-1040

Conversation

@redknightlois
Copy link
Member

Issue link

https://issues.hibernatingrhinos.com/issue/RDBC-1040

Additional description

RDBC-1040 – Adds JavaScriptArray.remove_all(predicate_js) to the patch scripting API. The method emits a JavaScript filter expression that removes all array elements matching the given predicate, assigning the result back to the field — equivalent to C# JavaScriptArray.RemoveAll. Complements the existing add() and put() operations on patchable arrays.

Type of change

  • Bug fix
  • Regression bug fix
  • Optimization
  • New feature

How risky is the change?

  • Low
  • Moderate
  • High
  • Not relevant

Backward compatibility

  • Non breaking change
  • Ensured. Please explain how has it been implemented?
  • Breaking change
  • Not relevant

Is it platform specific issue?

  • Yes. Please list the affected platforms.
  • No

Documentation update

  • This change requires a documentation update. Please mark the issue on YouTrack using Documentation Required tag.
  • No documentation update is needed

Testing by Contributor

  • Tests have been added that prove the fix is effective or that the feature works
  • Internal classes added to the test class (e.g. entity or index definition classes) have the lowest possible access modifier (preferable private)
  • It has been verified by manual testing
  • Existing tests verify the correct behavior

Testing by RavenDB QA team

  • This change requires a special QA testing due to possible performance or resources usage implications (CPU, memory, IO). Please mark the issue on YouTrack using QA Required tag.
  • No special testing by RavenDB QA team is needed

Is there any existing behavior change of other features due to this change?

  • Yes. Please list the affected features/subsystems and provide appropriate explanation
  • No

UI work

  • It requires further work in the Studio. Please mark the issue on YouTrack using Studio Required tag.
  • No UI work is needed

Emits 'this.{path} = this.{path}.filter(function(item){ return !(predicate); });'
matching the C# RemoveAll behavior (filter with negated predicate, assignment back to path).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant