RDBC-1042 URL-decode Database-Missing header before raising DatabaseDoesNotExistException#282
Open
redknightlois wants to merge 1 commit intoravendb:v7.1from
Open
RDBC-1042 URL-decode Database-Missing header before raising DatabaseDoesNotExistException#282redknightlois wants to merge 1 commit intoravendb:v7.1from
redknightlois wants to merge 1 commit intoravendb:v7.1from
Conversation
6f136a4 to
0c1bb08
Compare
…oesNotExistException Server sets this header via Uri.EscapeDataString; decode with urllib.parse.unquote before passing to the exception, matching C# Uri.UnescapeDataString behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1042
Additional description
RDBC-1042 – When a request targets a database with special characters in its name (spaces, Unicode, etc.), the server sets the
Database-Missingheader usingUri.EscapeDataString, producing a percent-encoded value such asmy%20db. The Python client was raisingDatabaseDoesNotExistExceptionwith the raw encoded string, making the error message unreadable. Fixed by decoding the header value withurllib.parse.unquotebefore constructing the exception, matching C#Uri.UnescapeDataStringbehavior.Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.