Open
Conversation
- Remove multi_json dependency, use stdlib JSON - Remove IO monkey patch, use IO.select-based timeout in Transcoder - Replace Travis CI with GitHub Actions - Fix rotation detection for modern ffmpeg (side_data_list) - Fix SSL detection (scheme instead of port) - Add frozen_string_literal to all files - Ruby 3.x/4.0 compatibility fixes
Replace manual IO.select/read_nonblock loop with IO#timeout=, drop require 'timeout' and use IO::TimeoutError directly.
Remove defunct Travis/CodeClimate badges and Streamio logo, update Ruby compatibility to 3.3+, simplify ffmpeg version guidance, and update examples to use keyword arguments for transcoder options.
Add duration: 0.5 to transcoding tests that don't care about full movie length, reducing ffmpeg work per test. Also add .ruby-version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi_jsondependency, use stdlibJSONIOmonkey patch, useIO.select-based timeout in Transcoderside_data_list)frozen_string_literalto all files