Reanalyze server: invalidate cache on config change#8262
Open
cristianoc wants to merge 1 commit intomasterfrom
Open
Reanalyze server: invalidate cache on config change#8262cristianoc wants to merge 1 commit intomasterfrom
cristianoc wants to merge 1 commit intomasterfrom
Conversation
cristianoc
force-pushed
the
reanalyze-server-config-invalidation
branch
from
f895bc6 to
98b7a21
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98b7a21c8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
|
I guess the issue was in the wrong repo then, I'll move it over. |
Re-read rescript.json before each server request and recreate the reactive pipeline from scratch when the reanalyze config changes (suppress, unsuppress, analysis mode, transitive). Closes rescript-lang/rescript-vscode#1180 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cristianoc
force-pushed
the
reanalyze-server-config-invalidation
branch
from
98b7a21 to
bef511d
Compare
cristianoc
requested review from
fhammerschmidt
and removed request for
fhammerschmidt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rescript.jsonbefore each server request and compare with a saved config snapshotRunConfig.snapshot/reset/equal_snapshotfor config change detectionreactive_pipelinetype andcreate_reactive_pipelinehelper in the serverCloses #8266
Test plan
run_scenario_config_changeintest-reactive-server.shvalidates this end-to-endbash tests/analysis_tests/tests-reanalyze/deadcode/test-reactive-server.sh --iterations 1passes🤖 Generated with Claude Code