Skip to content

chore(web): remove unnecessary use effect call#3024

Merged
gabrielmfern merged 2 commits intoresend:canaryfrom
dielduarte:remove-unnecessary-use-effect
Mar 12, 2026
Merged

chore(web): remove unnecessary use effect call#3024
gabrielmfern merged 2 commits intoresend:canaryfrom
dielduarte:remove-unnecessary-use-effect

Conversation

@dielduarte
Copy link
Contributor

@dielduarte dielduarte commented Mar 6, 2026

Hey team 👋

I was doing some exploration to understand better the codebase, and noticed this unnecessary use effect call, feels like a left over from an old implementations maybe, but there is no activeView props, so we don't need to keep internal state in sync, and the state already starts with desktop as initial value.

Quick one, hope it helps.

Lmk if I'm missing anything to be able to review the PR accordingly.

Cheers!


Summary by cubic

Removed a redundant useEffect in ComponentView that set activeView to itself on mount. Simplifies the component with no behavior change.

Written for commit 17a9a53. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Mar 6, 2026

@dielduarte is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: 17a9a53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@dielduarte dielduarte changed the title chore(web docs): remove unnecessary use effect call chore(web): remove unnecessary use effect call Mar 6, 2026
@gabrielmfern
Copy link
Member

Thank you!

@gabrielmfern gabrielmfern changed the title chore(web): remove unnecessary use effect call chore(web): remove unnecessary use effect call Mar 12, 2026
@gabrielmfern gabrielmfern merged commit ded81d5 into resend:canary Mar 12, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants