chore(web): remove unnecessary use effect call#3024
Merged
gabrielmfern merged 2 commits intoresend:canaryfrom Mar 12, 2026
Merged
chore(web): remove unnecessary use effect call#3024gabrielmfern merged 2 commits intoresend:canaryfrom
gabrielmfern merged 2 commits intoresend:canaryfrom
Conversation
|
@dielduarte is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
|
gabrielmfern
approved these changes
Mar 12, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team 👋
I was doing some exploration to understand better the codebase, and noticed this unnecessary use effect call, feels like a left over from an old implementations maybe, but there is no activeView props, so we don't need to keep internal state in sync, and the state already starts with
desktopas initial value.Quick one, hope it helps.
Lmk if I'm missing anything to be able to review the PR accordingly.
Cheers!
Summary by cubic
Removed a redundant useEffect in
ComponentViewthat setactiveViewto itself on mount. Simplifies the component with no behavior change.Written for commit 17a9a53. Summary will update on new commits.