Skip to content

fix: linting#3046

Closed
gabrielmfern wants to merge 1 commit intocanaryfrom
cursor/manual-linting-issues-61d5
Closed

fix: linting#3046
gabrielmfern wants to merge 1 commit intocanaryfrom
cursor/manual-linting-issues-61d5

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Mar 11, 2026

fix(react-email): linting

This PR addresses a noParameterAssign linting error in packages/markdown/src/markdown.tsx. The text parameter within the renderer.code callback was being reassigned, which violates a Biome rule configured as an error.

The fix introduces a new normalizedText variable to store the modified value, preventing direct parameter reassignment and resolving the linting issue.

Slack Thread

Open in Web Open in Cursor 

Summary by cubic

Fixes a Biome lint error in packages/markdown/src/markdown.tsx by avoiding parameter reassignment in the renderer.code callback. Introduces normalizedText to keep the same output while satisfying the noParameterAssign rule.

Written for commit 4bcb818. Summary will update on new commits.

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@cursor
Copy link

cursor bot commented Mar 11, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: 4bcb818

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Mar 11, 2026 3:45pm
react-email-demo Ready Ready Preview, Comment Mar 11, 2026 3:45pm

Request Review

@gabrielmfern gabrielmfern changed the title Manual linting issues fix: linting Mar 11, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/markdown@3046

commit: fa466ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants