Skip to content

fix: timestamp column selection in explore not persiting#9075

Draft
AdityaHegde wants to merge 3 commits intomainfrom
fix/timestamp-column-not-peristing-across-refreshes
Draft

fix: timestamp column selection in explore not persiting#9075
AdityaHegde wants to merge 3 commits intomainfrom
fix/timestamp-column-not-peristing-across-refreshes

Conversation

@AdityaHegde
Copy link
Collaborator

Timestamp column selection in explore does not persist across refreshes. This is because we were checking the selection against non-time dimensions which always failed.

Also added some missing unit tests for converting url params to explore state.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant