no-issue: disable tests conditionally when binary is not present

[ricardozanini]

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Sometimes, a local machine environment might not have python or protoc installed to run "unit" tests. In my opinion, these tests should be ITs and be on a specific profile.

However, if we want to run as unit tests and they depend on the environment where they're running, we disable the test if needed.

Special notes for reviewers:
mvn clean install now runs smoothly if python or grpc are not available.

Additional information (if needed):

[Copilot]

Pull request overview

Adds a JUnit 5 annotation/extension to conditionally disable tests when required external binaries (e.g., protoc, python) are not available on the executing machine, improving mvn clean install reliability across environments.

Changes:

• Introduce @DisabledIfBinaryUnavailable plus BinaryCheckCondition JUnit 5 ExecutionCondition.
• Apply the new annotation to gRPC tests requiring protoc.
• Apply the new annotation to the parameterized custom function test requiring python.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfBinaryUnavailable.java	New annotation to register the binary-check execution condition.
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java	New JUnit 5 ExecutionCondition that runs a command to determine binary availability.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryTest.java	Disable test class when protoc is unavailable.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java	Disable test class when protoc is unavailable.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcServerStreamingTest.java	Disable test class when protoc is unavailable.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcClientStreamingTest.java	Disable test class when protoc is unavailable.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcBiDirectionalStreamingTest.java	Disable test class when protoc is unavailable.
impl/test/src/test/java/io/serverlessworkflow/impl/test/CustomFunctionTest.java	Disable the python-dependent parameterized test when python is unavailable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[fjtirado]

Suggested change

	try {
	Process process =
	new ProcessBuilder(command)
	.redirectErrorStream(true)
	.redirectOutput(ProcessBuilder.Redirect.DISCARD)
	.start();
	boolean finished = process.waitFor(2, TimeUnit.SECONDS);
	if (finished) {
	return process.exitValue() == 0;
	}
	process.destroyForcibly();
	return false;
	} catch (IOException | InterruptedException e) {
	if (e instanceof InterruptedException) {
	Thread.currentThread().interrupt();
	}
	return false;
	}
	ProcessBuilder processBuilder =
	new ProcessBuilder(command)
	.redirectErrorStream(true)
	.redirectOutput(ProcessBuilder.Redirect.DISCARD);
	Process process = null;
	try {
	process = process.start();
	return process.waitFor(2, TimeUnit.SECONDS) && process.exitValue() == 0;
	} catch (IOException e) {
	// return default value
	}
	catch (InterruptedException e) {
	Thread.currentThread().interrupt();
	}
	finally {
	if (process != null) {
	process.destroyForcibly();
	}
	}
	return false;

[fjtirado]

You will need to format this, but the idea is always destroy the process (with current implementation if it is not destroyed if something goes wrong), do not wrap process builder within the finally block and return false except when there is a process to query about.
And also avoid and unneeded instanceof by using two catch blocks.

[fjtirado]

Another alternative can be

Suggested change

	try {
	Process process =
	new ProcessBuilder(command)
	.redirectErrorStream(true)
	.redirectOutput(ProcessBuilder.Redirect.DISCARD)
	.start();
	boolean finished = process.waitFor(2, TimeUnit.SECONDS);
	if (finished) {
	return process.exitValue() == 0;
	}
	process.destroyForcibly();
	return false;
	} catch (IOException | InterruptedException e) {
	if (e instanceof InterruptedException) {
	Thread.currentThread().interrupt();
	}
	return false;
	}
	Process process;
	try {
	process = new ProcessBuilder(command)
	.redirectErrorStream(true)
	.redirectOutput(ProcessBuilder.Redirect.DISCARD).start();
	} catch (IOException e) {
	return false;
	}
	try {
	return process.waitFor(2, TimeUnit.SECONDS) && process.exitValue() == 0;
	}
	catch (InterruptedException e) {
	Thread.currentThread().interrupt();
	return false;
	}
	finally {
	process.destroyForcibly();
	}

[fjtirado]

Suggested change

	annotation -> {
	if (isProtocAvailable()) {
	return ConditionEvaluationResult.enabled(
	"Protoc is available for the current platform.");
	} else {
	return ConditionEvaluationResult.disabled(
	"Test disabled: Protoc not currently available not found.");
	}
	})
	annotation ->
	isProtocAvailable() ? ConditionEvaluationResult.enabled(
	"Protoc is available for the current platform.") : ConditionEvaluationResult.disabled(
	"Test disabled: Protoc not currently available not found."))