feat: add dkg injection script for dappnode with guide#33
Open
blockchainluffy wants to merge 1 commit intomainfrom
Open
feat: add dkg injection script for dappnode with guide#33blockchainluffy wants to merge 1 commit intomainfrom
blockchainluffy wants to merge 1 commit intomainfrom
Conversation
jannikluhn
approved these changes
Mar 19, 2026
jannikluhn
left a comment
jannikluhn
left a comment
There was a problem hiding this comment.
LGTM as far as I can tell, just one note that's not critical
| fi | ||
|
|
||
| TAR_ERROR_FILE="${TMP_DIR}/tar-extract.err" | ||
| if ! tar "${TAR_WARNING_FLAGS[@]}" -xf "$BACKUP_TARBALL_PATH" -C "$TMP_DIR" 2>"$TAR_ERROR_FILE"; then |
There was a problem hiding this comment.
I think it would be better if we extract not in into TMP_DIR, but into a subdirectory, for two reasons:
- if extraction fails, we can delete the directory before doing the second attempt with the
-Jflag. Currently, the first extraction attempt might leave the directory in an undefined state - the check below in line 159 can check for the contents of the subdirectory. Right now it is satisfied even if only the
tar-extract.errfile is created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.