improvement(mcp): add all MCP server tools individually instead of as single server entry#3376
Merged
waleedlatif1 merged 2 commits intostagingfrom Feb 27, 2026
Merged
Conversation
… single server entry
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryReplaces server-level MCP tool selection with individual tool entries. Previously, selecting "all tools" from an MCP server stored a single Key changes:
Already flagged in previous review:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before ["Before: Server-Level Selection"]
A1[User clicks 'Use all tools'] --> A2[Frontend stores single mcp-server entry]
A2 --> A3[Agent execution starts]
A3 --> A4[Backend processMcpServerSelections]
A4 --> A5[Backend discovers all tools from server]
A5 --> A6[Backend expands to individual tools]
A6 --> A7[LLM receives all tools]
end
subgraph After ["After: Individual Tool Selection"]
B1[User clicks 'Use all tools'] --> B2[Frontend immediately creates individual mcp entries]
B2 --> B3[User can configure each tool]
B3 --> B4[Agent execution starts]
B4 --> B5[Backend receives individual tools]
B5 --> B6[LLM receives configured tools]
end
style Before fill:#fee,stroke:#c88,stroke-width:2px
style After fill:#efe,stroke:#8c8,stroke-width:2px
Last reviewed commit: fb3fd2d |
...components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Show resolved
Hide resolved
...components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Show resolved
Hide resolved
...components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Show resolved
Hide resolved
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpStoredTools instead of onemcp-serverentrymcp-serverStoredTool type and all backend expansion logicType of Change
Testing
Tested manually. 44 agent-handler tests + 39 tool-validation tests pass.
Checklist