Add test targets for running specific, e2e, subset, and CI tests#2067
Open
rafaelvzago wants to merge 4 commits intoskupperproject:mainfrom
Open
Add test targets for running specific, e2e, subset, and CI tests#2067rafaelvzago wants to merge 4 commits intoskupperproject:mainfrom
rafaelvzago wants to merge 4 commits intoskupperproject:mainfrom
Conversation
fgiorgetti
reviewed
Apr 9, 2025
…with high availability test details
fgiorgetti
reviewed
Apr 17, 2025
Comment on lines
+158
to
+161
| make tests-e2e ci-tests | ||
|
|
||
| # Run all E2E tests from the root | ||
| make tests-e2e e2e-tests |
Member
There was a problem hiding this comment.
Should these be: test-e2e, instead?
| make test-e2e TEST_TYPE=test TEST_OPTIONS="TEST=hello-world" | ||
|
|
||
| # Run a specific test with a subset of tests from the root | ||
| make test-e2e TEST_TYPE=test-subset TEST_OPTIONS="TESTS=hello-world,attached-connector" |
Member
There was a problem hiding this comment.
The reason for my first comment is that it feels too complex to run samples like this one...
Comment on lines
+29
to
+32
| # The default e2e test type is set to "ci-tests" if not provided | ||
| TEST_TYPE ?= ci-tests | ||
| TEST_OPTIONS ?= "" | ||
|
|
Member
There was a problem hiding this comment.
What do you think of making it simpler, by introducing just one variable, like E2E_OPTIONS ?= ci-tests ?
With that, the test-e2e target below, could be simplified into something like:
$(MAKE) -C tests/ $(E2E_OPTIONS)
And the execution could be done as:
make test-e2e
make test-e2e E2E_OPTIONS="e2e-tests"
make test-e2e E2E_OPTIONS="test TEST=hello-world"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test targets for running specific, e2e, subset, and CI tests.
Closes #2063