Skip to content

added firing sdk ready event #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chillaq wants to merge 1 commit into
base: feature/sdk-events
Choose a base branch
from
Open

added firing sdk ready event #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/splitclient-rb/engine/status_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
module SplitIoClient
module Engine
class StatusManager
def initialize(config)
def initialize(config, internal_events_queue)
@config = config
@sdk_ready = Concurrent::CountDownLatch.new(1)
@internal_events_queue = internal_events_queue
end

def ready?
Expand All @@ -19,6 +20,10 @@ def ready!

@sdk_ready.count_down
@config.logger.info('SplitIO SDK is ready')
@internal_events_queue.push(
SplitIoClient::Engine::Models::SdkInternalEventNotification.new(
SplitIoClient::Engine::Models::SdkInternalEvent::SDK_READY, nil)
)
end

def wait_until_ready(seconds = nil)
Expand Down
19 changes: 16 additions & 3 deletions spec/engine/status_manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,16 @@
subject { SplitIoClient::Engine::StatusManager }

let(:config) { SplitIoClient::SplitConfig.new(logger: Logger.new(StringIO.new)) }
let(:queue) {Queue.new}

it 'check if sdk is ready - should return false' do
status_manager = subject.new(config)
status_manager = subject.new(config, queue)

expect(status_manager.ready?).to eq(false)
end

it 'check if sdk is ready - should return true' do
status_manager = subject.new(config)
status_manager = subject.new(config, queue)

expect(status_manager.ready?).to eq(false)

Expand All @@ -23,11 +24,23 @@
end

it 'wait until ready - should return false' do
status_manager = subject.new(config)
status_manager = subject.new(config, queue)

expect { status_manager.wait_until_ready(0.5) }.to raise_error(SplitIoClient::SplitIoError, 'SDK start up timeout expired')

status_manager.ready!
expect { status_manager.wait_until_ready(0) }.not_to raise_error
end

it 'check if sdk is ready - should fire ready event' do
status_manager = subject.new(config, queue)

expect(status_manager.ready?).to eq(false)

status_manager.ready!
expect(status_manager.ready?).to eq(true)
event = queue.pop
expect(event.internal_event).to be(SplitIoClient::Engine::Models::SdkInternalEvent::SDK_READY)
expect(event.metadata).to be(nil)
end
end