Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
with:
toolchain: ${{ steps.rust-version.outputs.rust-version }}

- name: Add wasm32-wasi target
run: rustup target add wasm32-wasip1
- name: Add wasm targets
run: rustup target add wasm32-wasip1 wasm32-unknown-unknown

- name: Setup Viceroy
run: cargo install viceroy --locked
Expand All @@ -57,3 +57,9 @@ jobs:

- name: Check feature compilation
run: cargo check --workspace --all-targets --features "fastly cloudflare"

- name: Check Fastly wasm target
run: cargo check -p edgezero-adapter-fastly --features fastly --target wasm32-wasip1

- name: Check Cloudflare wasm target
run: cargo check -p edgezero-adapter-cloudflare --features cloudflare --target wasm32-unknown-unknown
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# node
node_modules/

# compiled output
bin/
pkg/
target/
.wrangler/
.edgezero/

# env
.env
Expand Down
14 changes: 14 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ log = "0.4"
log-fastly = "0.11"
matchit = "0.9"
once_cell = "1"
redb = "3.1.0"
reqwest = { version = "0.13", default-features = false, features = ["rustls"] }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
Expand Down
23 changes: 20 additions & 3 deletions crates/edgezero-adapter-axum/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,26 @@ license = { workspace = true }

[features]
default = ["axum"]
axum = ["dep:axum", "dep:tokio", "dep:tower", "dep:futures-util", "dep:reqwest"]
cli = ["dep:edgezero-adapter", "edgezero-adapter/cli", "dep:ctor", "dep:toml", "dep:walkdir"]
axum = [
"dep:axum",
"dep:tokio",
"dep:tower",
"dep:futures-util",
"dep:reqwest",
"dep:redb",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: serde_json is added to the axum feature gate but never used in adapter source code.

grep -r serde_json crates/edgezero-adapter-axum/src/ returns zero matches. Same for Fastly adapter (Cargo.toml line 37). This adds unnecessary build graph churn.

If these were added speculatively for future use, remove them and add back when needed.

cli = [
"dep:edgezero-adapter",
"edgezero-adapter/cli",
"dep:ctor",
"dep:toml",
"dep:walkdir",
]

[dependencies]
edgezero-adapter = { path = "../edgezero-adapter", optional = true, features = ["cli"] }
edgezero-adapter = { path = "../edgezero-adapter", optional = true, features = [
"cli",
] }
edgezero-core = { path = "../edgezero-core" }
anyhow = { workspace = true }
async-trait = { workspace = true }
Expand All @@ -22,6 +37,7 @@ futures = { workspace = true }
futures-util = { workspace = true, optional = true }
http = { workspace = true }
log = { workspace = true }
redb = { workspace = true, optional = true }
reqwest = { workspace = true, optional = true }
simple_logger = { workspace = true }
thiserror = { workspace = true }
Expand All @@ -34,5 +50,6 @@ walkdir = { workspace = true, optional = true }
[dev-dependencies]
async-trait = { workspace = true }
axum = { workspace = true, features = ["macros"] }
serde = { workspace = true }
tempfile = { workspace = true }
tokio = { workspace = true, features = ["macros", "rt", "rt-multi-thread"] }
Loading
Loading