ROX-28981: Split methods for collector iservice#2085
Draft
Molter73 wants to merge 1 commit intomauro/ROX-28526-use-collector-iservicefrom
Draft
ROX-28981: Split methods for collector iservice#2085Molter73 wants to merge 1 commit intomauro/ROX-28526-use-collector-iservicefrom
Molter73 wants to merge 1 commit intomauro/ROX-28526-use-collector-iservicefrom
Conversation
9 tasks
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## mauro/ROX-28526-use-collector-iservice #2085 +/- ##
==========================================================================
+ Coverage 26.96% 27.02% +0.06%
==========================================================================
Files 98 98
Lines 6060 6046 -14
Branches 2703 2701 -2
==========================================================================
Hits 1634 1634
+ Misses 3707 3693 -14
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Molter73
force-pushed
the
mauro/ROX-28981-rework-collector-iservice-protobuf
branch
2 times, most recently
from
85cb9c6 to
ffbe42c
Compare
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
ddfe9e2 to
9a81385
Compare
Molter73
force-pushed
the
mauro/ROX-28981-rework-collector-iservice-protobuf
branch
from
ffbe42c to
efc1c53
Compare
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
9a81385 to
785dffb
Compare
Molter73
force-pushed
the
mauro/ROX-28981-rework-collector-iservice-protobuf
branch
from
efc1c53 to
6f05199
Compare
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
785dffb to
81a7b0c
Compare
Molter73
force-pushed
the
mauro/ROX-28981-rework-collector-iservice-protobuf
branch
from
6f05199 to
51fdfaa
Compare
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
81a7b0c to
a1d1772
Compare
Due to a limitation on collector side with the C++ gRPC API, we have decided to split the RPC method into one per message type collector can send. This patch changes and regenerates the protobuf definitions and reworks the collector service to comply with the new definition.
Molter73
force-pushed
the
mauro/ROX-28981-rework-collector-iservice-protobuf
branch
from
51fdfaa to
fcac496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to a limitation on collector side with the C++ gRPC API, we have decided to split the RPC method into one per message type collector can send.
This patch changes and regenerates the protobuf definitions and reworks the collector service to comply with the new definition.
Sibling PR: stackrox/stackrox#14991
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.