Skip to content

Add remaining FlixelTweenTypes LOOPING, PINGPONG and BACKWARD#58

Merged
stringdotjar merged 14 commits intostringdotjar:developfrom
jfsaaved:feature/sub-issue-38-remaining_tweens
Mar 10, 2026
Merged

Add remaining FlixelTweenTypes LOOPING, PINGPONG and BACKWARD#58
stringdotjar merged 14 commits intostringdotjar:developfrom
jfsaaved:feature/sub-issue-38-remaining_tweens

Conversation

@jfsaaved
Copy link

@jfsaaved jfsaaved commented Mar 7, 2026

Issue: #38

  • Add LOOPING, PINGPONG, and BACKWARD to FlixelTweens
  • Add active variable
  • Add delayToUse variable
  • Add waitingForRestart variable

Description

The goal is to include the BACKWARD, LOOPING and PINGPONG tween types to allow further control of the tweening system.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor / Optimization

Checklist

  • My PR targets the develop branch, not master/main.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes pass all automated build checks.
  • I have updated the documentation accordingly (if applicable).
  • I have added tests that prove my fix is effective or that my feature works.

Screenshots / Evidence (if applicable)

PINGPONG
looping_flixel

LOOPING
pingpong_flixel

BACKWARD
backward_flixel

- AddLOOPING, PINGPONG, and BACKWARD to FlixelTweens
- Add active variable
- Add delayToUse variable
- Add waitingForRestart variable
jfsaaved added 4 commits March 7, 2026 06:39
- Fix FlixelPropertyTween math for new value
- Revert changes on FlixelTween update
- Add begind for snapshotarray
…nto feature/sub-issue-38-remaining_tweens
@jfsaaved jfsaaved marked this pull request as draft March 7, 2026 12:49
@jfsaaved jfsaaved marked this pull request as ready for review March 7, 2026 12:50
@stringdotjar stringdotjar moved this from 🗒️ Todo to 🏗️ In Progress in FlixelGDX Project Board Mar 7, 2026
@stringdotjar stringdotjar added enhancement New feature or request core Core logic module of the framework tweening Custom tweening system for adding animations on objects labels Mar 7, 2026
@stringdotjar stringdotjar changed the title [WIP] Adding remaining FlixelTweens - LOOPING, PINGPONG, BACKWARD Add remaining FlixelTweens LOOPING, PINGPONG and BACKWARD Mar 7, 2026
@stringdotjar stringdotjar changed the title Add remaining FlixelTweens LOOPING, PINGPONG and BACKWARD Add remaining FlixelTweenTypes LOOPING, PINGPONG and BACKWARD Mar 7, 2026
Copy link
Owner

@stringdotjar stringdotjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! There's just a few things to do left you need to do before I merge it into the codebase:

  • Fix your formatting to match what's in the .editorconfig file. Remember, we want the codebase to look like it was written by a single person
  • Update the Javadocs and your comments as stated in the GitHub comments I left
  • When the tween restarts, it goes back to the starting values where the tween started at before the tween started. This should not happen. For example, if a sprite had its x field start at 0f, and it's being tweened to 400f, and it was cancelled and restarted at 200f, it should restart and begin at 200f, not back from 0f. This applies to all tween types
  • Refactor destroy() to use the reset() method and replace the resetBasic() call in reset() to use destroy(), as we want both methods to do the same thing for backwards compatibility

@stringdotjar stringdotjar added the needs changes This pull request needs changes before it can be merged label Mar 7, 2026
@stringdotjar stringdotjar moved this from 🏗️ In Progress to Needs Improvements in FlixelGDX Project Board Mar 8, 2026
@stringdotjar stringdotjar marked this pull request as draft March 8, 2026 20:50
@jfsaaved jfsaaved marked this pull request as ready for review March 10, 2026 01:15
@stringdotjar stringdotjar moved this from 🔧 Needs Changes to 🚧 Awaiting Approval in FlixelGDX Project Board Mar 10, 2026
@stringdotjar stringdotjar moved this from 🚧 Awaiting Approval to 💯 Approved in FlixelGDX Project Board Mar 10, 2026
Copy link
Owner

@stringdotjar stringdotjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice j*b! I'll merge it for you :>

@stringdotjar stringdotjar merged commit 24932fd into stringdotjar:develop Mar 10, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from 💯 Approved to ✅ Completed in FlixelGDX Project Board Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core logic module of the framework enhancement New feature or request needs changes This pull request needs changes before it can be merged tweening Custom tweening system for adding animations on objects

Projects

Status: ✅ Completed

Development

Successfully merging this pull request may close these issues.

2 participants