Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the mustache dependency from the RLS test suite by replacing Mustache rendering with a small, purpose-built string interpolation helper.
Changes:
- Replaced
Mustache.render(...)usage insrc/test/rls.test.tswith a localrenderRlsTemplate(...)implementation. - Removed
mustacheand@types/mustachefrompackage.jsonand pruned them frompackage-lock.json.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/rls.test.ts | Introduces a lightweight {{var}} interpolator for test YAML templating and replaces Mustache usage. |
| package.json | Drops mustache and @types/mustache dev dependencies. |
| package-lock.json | Removes resolved entries for mustache and @types/mustache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TylerHillery
approved these changes
Mar 20, 2026
Contributor
TylerHillery
left a comment
There was a problem hiding this comment.
We are going to have no dependencies left by this rate you're removing them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
Mustache is used for RLS tests but we don't use any partials, blocks, etc. Instead simple interpolation.
What is the new behavior?
Use string replace with one liner to drop the dependency.
Additional context
The less dependency we need, the better it is for maintenance even if dev dependency.