Draft
Conversation
ed8c8a1 to
b5da1f0
Compare
Member
Author
|
draft for testing |
Member
Author
|
after setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #819
Port of synonymdev/bitkit-ios#480
This PR:
nullfor orphaned recovery — only monitors are needed for sweeping force-closed channelsDescription
When recovering orphaned channel monitors from an RN remote backup, the stale RN channel manager was being passed to LDK alongside the monitors. This overwrites the native app's current channel manager, which can force-close any existing channels the user has opened.
The recovery also ran after the node was already started, requiring an expensive stop/restart cycle. This change moves the fetch to before node initialization, so monitors are included in the initial LDK setup — matching the iOS approach.
Preview
QA Notes
./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detektisChannelRecoveryCheckedshort-circuits the check