PLT-951 Add PHP 8 support#158
Draft
mrliptontea wants to merge 5 commits intoPLT-951-modernise-codefrom
Draft
Conversation
- Enforce that ReadPreference is a string - Switch from ReadPreference->getMode() to getModeString()
mrliptontea
force-pushed
the
PLT-951-add-php-8-support
branch
from
0f63c9b to
0ada92c
Compare
mike-dean-talis
approved these changes
Mar 20, 2026
mike-dean-talis
left a comment
mike-dean-talis
left a comment
There was a problem hiding this comment.
Looks good to an untrained tripod-ist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$readPreferenceis a stringReadPreference->getMode()togetModeString()