Add support for specifying layout options and passing them to layout engines (starting with ELK)#2608
Open
alesya-h wants to merge 3 commits intoterrastruct:masterfrom
Open
Add support for specifying layout options and passing them to layout engines (starting with ELK)#2608alesya-h wants to merge 3 commits intoterrastruct:masterfrom
alesya-h wants to merge 3 commits intoterrastruct:masterfrom
Conversation
1c3da2b to
2c3545e
Compare
|
Very cool! |
1ec2f16 to
c353287
Compare
c353287 to
7ff8f5a
Compare
Author
|
I've rebased everything and updated commits to have my signature, so this presumably only needs maintainers' eyes at this point. |
Author
|
Can we have this reviewed and merged please? The actual change is fairly small, the diffstat only looks big because of a tiny update in tests that meant having to reaccept them (basically changing layout to _layout in a few places to not clash with the new keyword). It's been over 3 months and there's a risk it will get stale and gonna require rebasing. Pretty please? With a cherry on top? 🍒 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it
This introduces the keyword
layoutthat can be used at any level (root and subgraphs) and allows to specify and pass layout options directly to the layout engine. Explicit user options override default/autogenerated ones. See examples below.Help needed
While I have been coding for living for over 15 years, I never used go, so this was made with some AI help. Consequently, while it works, it might be not perfect and could benefit from a pair of human eyes reviewing and correcting it.
Potential improvements for later:
--layout elkon the command lineExamples