i.MX8: Add support for new board revisions#5303
Merged
dbaluta merged 3 commits intothesofproject:topic/sof-devfrom Jan 22, 2025
dbaluta:add_platf
Merged
i.MX8: Add support for new board revisions#5303dbaluta merged 3 commits intothesofproject:topic/sof-devfrom dbaluta:add_platf
dbaluta merged 3 commits intothesofproject:topic/sof-devfrom
dbaluta:add_platf
Conversation
dbaluta
requested review from
bardliao,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
LaurentiuM1234
approved these changes
Jan 21, 2025
iuliana-prodan
approved these changes
Jan 21, 2025
Collaborator
|
Would you like to address the typo in the commit message? https://sof-ci.01.org/linuxpr/PR5303/build5873/checkpatch/index.html |
After commit 2b9cdef ("ASoC: SOF: imx: Add devicetree support to select topologies") we select topology to be used by the board compatible string in the dts. Now that we have a way to know when the baseboard is installed, use the board compatible and select proper topology files when the cs42888 Audio IO card is used. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
The new revisions for 8QM and 8QXP have wm8962 codec instead of wm8960. Therefore add new entries in sof_imx8_machs, an array of snd_sof_of_mach, where we describe topology name and driver name. For the new revisions we have new compatible values and based on these, we select the new topology file, for wm8962 codec. Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> Reviewed-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
The new revision for 8M Plus has wm8962 codec instead of wm8960. Therefore add new entry in sof_imx8mp_machs, an array of snd_sof_of_mach, where we describe topology name and driver name. For the new revision we have new compatible value and based on this, we select the new topology file, for wm8962 codec. Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> Reviewed-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Collaborator
Author
|
@bardliao done. |
ujfalusi
approved these changes
Jan 22, 2025
bardliao
approved these changes
Jan 22, 2025
Collaborator
|
@dbaluta Would you like to submit the patches to ASoC tree by yourselves or you prefer us to submit them? |
lgirdwood
approved these changes
Jan 22, 2025
Collaborator
Author
|
@bardliao I will submit them myself to Asoc tree. |
Collaborator
Then we should not merge it into SOF tree here. Otherwise, we may have merge conflicts when we do the next upstream merge. Thanks. |
Collaborator
Author
|
@bardliao thanks for pointing out, I always took the patches from topic/sof-dev but I get your point. Will send v2 to community based on sof-dev-rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for new i.MX8MP, i.MX8QM and i.MX8QXP revisions and also help select the correct topology for cs42888 codec found on Audio IO card.