ASoC: amd: acp: Fix possible deadlock

[dbaluta]

On error path, function acp_i2s_set_tdm_slot returns without releasing the lock and this could result in potential deadlocks in the future.

Error reported by sparse:
sound/soc/amd/acp/acp-i2s.c:95:12: error: context imbalance in 'acp_i2s_set_tdm_slot' - different lock contexts for basic block

Fixes: cd60dec ("ASoC: amd: acp: Refactor TDM slots selction based on acp revision id")

[dbaluta]

@thesofproject/amd please have a look. This is only compile tested

[dbaluta]

@lgirdwood there is still one issue reported by static checkers.

https://github.com/thesofproject/linux/actions/runs/12911457389/job/36003910540?pr=5304

sound/soc/sof/ipc4-topology.c: In function ‘sof_ipc4_prepare_copier_module’:
sound/soc/sof/ipc4-topology.c:1810:34: error: use of uninitialized value ‘((int *)<unknown>)[2]’ [CWE-457] [-Werror=analyzer-use-of-uninitialized-value]
 1810 |         struct snd_pcm_hw_params ref_params;
      |                                  ^~~~~~~~~~
  ‘sof_ipc4_prepare_copier_module’: events 1-4
    |
    | 1810 |         struct snd_pcm_hw_params ref_params;
    |      |                                  ^~~~~~~~~~
    |      |                                  |
    |      |                                  (1) region created on stack here
    |      |                                  (2) following ‘true’ branch...
    |      |                                  (3) ...to here
    |      |                                  (4) use of uninitialized value ‘((int *)<unknown>)[2]’ here
    |
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:194: sound/soc/sof/ipc4-topology.o] Error 1

but I wasn't able to understand where is the problem. Could be a false positive?

[ranj063]

but I wasn't able to understand where is the problem. Could be a false positive?

@dbaluta looks like a false positive but perhaps will can init the ref_params to {} to silence the static analyzer?

[vijendarmukunda]

LGTM