Revert pipeline management restructure#5328
Merged
ranj063 merged 7 commits intothesofproject:topic/sof-devfrom Feb 13, 2025
Merged
Revert pipeline management restructure#5328ranj063 merged 7 commits intothesofproject:topic/sof-devfrom
ranj063 merged 7 commits intothesofproject:topic/sof-devfrom
Conversation
This reverts commit 38c4090. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…lag" This reverts commit e2b6395. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This reverts commit 45e374d. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This reverts commit 9232c22. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…elines" This reverts commit 962f8bb. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This reverts commit f14ac2b. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This reverts commit 259fa00. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
changed the title
Collaborator
Author
|
SOFCI TEST |
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
lyakh,
plbossart and
ranj063
as code owners
Collaborator
Author
|
@ranj063, taking this out from draft. The CI results confirm the worst that the original series introduced not trivial regressions even with IPC4. CI runs with this PR: Something goes wrong for sure and my fixup, while helping with IPC3, it still leaves IPC4 failing. |
lyakh
approved these changes
Feb 13, 2025
Collaborator
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
fixes the regression - tested on LNL nocodec
Member
ranj063
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the #5262 caused more failures than just in IPC3.
suspend with capture in IPC4 looks like to be affected and DSPless mode also got regressed around the same time.
Let's see if a revert of the changes can fix this and if it does, I think we should proceed with it unless the issues can be addressed.